Fix wrong doc on exit code #503
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to real world tests, the correct exit code here is 7, so I'm updating the man page to avoid confusion. See this session: ```bash [root@132973203c5d /]# gocryptfs -init root Invalid cipherdir: directory /root not empty [root@132973203c5d /]# echo $? 7 [root@132973203c5d /]# gocryptfs --version gocryptfs v1.8.0-Fedora-1.8.0-1.fc32; go-fuse 1.0.1; 2020-05-21 go1.14.2 linux/amd64 ```
rfjakob
added a commit
that referenced
this pull request
Sep 6, 2020
|
Hi, thanks for the report! I looked at this, and I think gocryptfs returns the wrong exit code. So I fixed that and kept the docs as-is: 993b19c . |
|
PS: The fix will appear in gocryptfs v2.0, which currently being developed in the gofuse_v2api branch |
mpobaschnig
added a commit
to mpobaschnig/vaults
that referenced
this pull request
Nov 1, 2021
With gocryptfs v2.0, error codes were fixed, see: rfjakob/gocryptfs#503
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to real world tests, the correct exit code here is 7, so I'm updating the man page to avoid confusion.
See this session: