Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extraClasses option #202

Merged
merged 3 commits into from
Aug 25, 2021
Merged

Add extraClasses option #202

merged 3 commits into from
Aug 25, 2021

Conversation

yatharth
Copy link
Contributor

@yatharth yatharth commented Aug 25, 2021

Just adding an extraClasses string option to allow people to add any styling they need to on the notification element created by bulma-toast.

For example, I used extraClasses to pass in is-light py-3 px-4 to make the notifications look how I want them too. There wasn’t a particularly elegant non-Javascript way to accomplish this otherwise while reusing Bulma classes.

Addresses #203.

@rfoel rfoel merged commit 188058a into rfoel:main Aug 25, 2021
rfoel pushed a commit that referenced this pull request Aug 30, 2021
* Add extraClasses option

* Bump minor version number

* Fix typo in variable

* Bump patch number

* Update lockfile to match patch number + upgrade lockfile to newer format
rfoel pushed a commit that referenced this pull request Aug 30, 2021
* Add extraClasses option

* Bump minor version number

* Fix typo in variable

* Bump patch number

* Update lockfile to match patch number + upgrade lockfile to newer format
github-actions bot pushed a commit that referenced this pull request Aug 30, 2021
## [2.4.1](v2.4.0...v2.4.1) (2021-08-30)

### Bug Fixes

* fix merge of PR [#202](#202) ([#205](#205)) ([e4b931d](e4b931d))
@yatharth yatharth deleted the extra_classes branch August 31, 2021 03:29
@yatharth yatharth restored the extra_classes branch August 31, 2021 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants