Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mistyped ElasticsearchAppender#layout field causing plugin injection errors #33

Closed
vy opened this issue Jan 13, 2020 · 2 comments
Closed

Mistyped ElasticsearchAppender#layout field causing plugin injection errors #33

vy opened this issue Jan 13, 2020 · 2 comments

Comments

@vy
Copy link

vy commented Jan 13, 2020 •
edited
Loading

ElasticsearchAppender.Builder#layout is of type AbstractLayout, whereas it should have been Layout. See Log4j 2.0 FileAppender for an example. This renders ElasticsearchAppender unusable for layouts that don't extend from AbstractLayout. For instance, LogstashLayout doesn't extend from AbstractLayout class, but implements Layout<String> interface, hence the Log4j field injection failure reported in #32.
This was referenced Jan 13, 2020
Closed
Closed
@rfoltyns
Copy link
Owner

I don't believe that the parameter is "mistyped". It's much easier to relax the interface than tighten one in the future (it started from JsonLayout btw).

But, to improve compatibility with other layouts, I'll relax it in 1.4.

rfoltyns added a commit that referenced this issue Feb 4, 2020
@rfoltyns
AbstracLayout changed to Layout (#33)
0a5ec7a
rfoltyns added a commit that referenced this issue Feb 4, 2020
@rfoltyns
AbstractLayout changed to Layout (#33)
1ff08e6
@rfoltyns
Copy link
Owner

rfoltyns commented Mar 7, 2020

Fixed in 1.4.

@rfoltyns rfoltyns closed this as completed Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vy @rfoltyns