Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Estimate precursor intensities for MS2 spectra #202

Closed
jorainer opened this issue May 6, 2021 · 1 comment
Closed

Estimate precursor intensities for MS2 spectra #202

jorainer opened this issue May 6, 2021 · 1 comment
Assignees
@jorainer
Labels
enhancement New feature or request

Comments

@jorainer
Copy link
Member

jorainer commented May 6, 2021

This is coming from jorainer/SpectraTutorials#6 . Some instruments don't report precursor intensities, but it's straight forward to calculate them based on MS1 spectra data. The functionality for OnDiskMSnExp objects is currently implemented in xcms::estimatePrecursorIntensity - we should also implement that for Spectra.
@jorainer jorainer self-assigned this May 6, 2021
@jorainer jorainer added the enhancement New feature or request label May 6, 2021
jorainer added a commit that referenced this issue May 7, 2021
@jorainer
feat: add estimatePrecursorIntensity (issue #202)
49bf2ec
jorainer added a commit that referenced this issue Jun 7, 2021
@jorainer
Merge pull request #203 from rformassspectrometry/jomain
771c430 
feat: add estimatePrecursorIntensity (issue #202)
@jorainer
Copy link
Member Author

jorainer commented Jun 7, 2021

Done

@jorainer jorainer closed this as completed Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jorainer jorainer

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jorainer