Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compareSpectra to always (by default) return a matrix #219

Closed
jorainer opened this issue Oct 21, 2021 · 2 comments
Closed

compareSpectra to always (by default) return a matrix #219

jorainer opened this issue Oct 21, 2021 · 2 comments

Comments

@jorainer
Copy link
Member

Add a drop = FALSE parameter to compareSpectra so that results are always returned as a matrix even if the number of query or target spectra is 1. (see jorainer/SpectraTutorials#27 for reference).
@sgibb
Copy link
Member

sgibb commented Oct 21, 2021

Don't we have a SIMPLIFY argument already? Isn't it working with SIMPLIFY = FALSE? Maybe we should change the default or drop this argument at all?

@jorainer
Copy link
Member Author

Yes, we have that argument, thanks @sgibb (I added that issue without looking into the code) And yes, maybe we could change the default - I'll look into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgibb @jorainer