fix: ensure backend is changed in Spectra,character constructor #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix that the backend is changed even if the backend passed with `source` extends the backend specified with `backend` (issue #146).
Closed
|
Looks good, but could you point me to the issue or example that triggered this change. I can only vaguely remember it. |
lgatto
approved these changes
Oct 16, 2020
|
Merged now. Olly, could you install from Github with BiocManager::install("RforMassSpectrometry/Spectra")and confirm that it now works. |
|
@jorainer - I tried to push to Bionconductor, but don't have access. Will email Nitesh and cc you. |
|
On Bioc (devel) too, now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sourceextends the backend specified with
backend(issue manipulating spectraData clears peaksData #146).