Add support for -w when iptables >= 1.4.20 #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfxn
approved these changes
Nov 17, 2020
rfxn
added a commit
that referenced
this pull request
Nov 18, 2020
[New] add iptables locking support with iptables >= 1.4.20; pr #36 IPT_LOCK_SUPPORT IPT_LOCK_TIMEOUT [Fix] typos
rfxn
added a commit
that referenced
this pull request
Nov 18, 2020
[New] add iptables locking support with iptables >= 1.4.20; pr #36 IPT_LOCK_SUPPORT IPT_LOCK_TIMEOUT [Fix] typos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When two instances of the
iptablescommand are ran simultaneously they often encounter a race condition resulting in one of the commands not being executed. mutex_lock/unlock stops two instances ofapffrom colliding, but external programs that calliptablesdirectly may result inapfnot adding the necessary rules.In 1.4.20, iptables added native support for locking, as well as a wait timeout flag:
http://git.netfilter.org/iptables/commit/?id=93587a04d0f2511e108bbc4d87a8b9d28a5c5dd8
http://git.netfilter.org/iptables/commit/?id=d7aeda5ed45ac7ca959f12180690caa371b5b14b
This PR adds the flag with a default timeout of 3 seconds when iptables is >= 1.4.20.