Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed vrt.be, sporza.be and removed old sites. #20527

Closed
wants to merge 3 commits into from
Closed

Fixed vrt.be, sporza.be and removed old sites. #20527

wants to merge 3 commits into from

Conversation

principis
Copy link

@principis principis commented Apr 1, 2019

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.

I removed deredactie.be, cobra.be and cobra.canvas.be because they do not exist anymore.
This also fixes vrt.be and sporza.be which was not working anymore because the website were overhauled.

Let me know if I need to change anything!

@rdehuyss
Copy link

rdehuyss commented Apr 2, 2019

I can confirm the fix works.

@rdehuyss
Copy link

rdehuyss commented Apr 2, 2019

@principis Is it possible to use youtube-dl for the livestream? I get a 500 error when using the live stream, all other url's work fine!

@principis
Copy link
Author

@principis Is it possible to use youtube-dl for the livestream? I get a 500 error when using the live stream, all other url's work fine!

I don't think so. I can try to make a fix for it but I'm not that experienced with it. :)

@principis
Copy link
Author

Is it possible for this to be merged? Or do I need to change something?

meunierd referenced this pull request in meunierd/youtube-dl Dec 27, 2019
meunierd referenced this pull request in meunierd/youtube-dl Feb 13, 2020
@nicerman1
Copy link

I tried to download a video from vrtNU, which gave me an extraction error for the title:

[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['https://www.vrt.be/vrtnu/a-z/clinch/1/clinch-s1a1/', '--verbose']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2020.07.28
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.18362
[debug] exe versions: ffmpeg 4.2.2, ffprobe 4.2.2
[debug] Proxy map: {}
[VrtNU] clinch-s1a1: Downloading webpage
[VrtNU] clinch-s1a1: Downloading JSON metadata
[Canvas] pbs-pub-ec963391-e39f-404a-8fbb-5fe95f60012e$vid-4baec8da-1583-4b09-a724-3d12369a92b4: Downloading asset JSON
WARNING: Unable to download asset JSON: HTTP Error 410: Gone
[Canvas] pbs-pub-ec963391-e39f-404a-8fbb-5fe95f60012e$vid-4baec8da-1583-4b09-a724-3d12369a92b4: Downloading token
[Canvas] pbs-pub-ec963391-e39f-404a-8fbb-5fe95f60012e$vid-4baec8da-1583-4b09-a724-3d12369a92b4: Downloading video JSON
ERROR: An extractor error has occurred. (caused by KeyError('title',)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type youtube-dl -U to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpq2whuxta\build\youtube_dl\extractor\common.py", line 530, in extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpq2whuxta\build\youtube_dl\extractor\canvas.py", line 74, in _real_extract
KeyError: 'title'
Traceback (most recent call last):
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpq2whuxta\build\youtube_dl\extractor\common.py", line 530, in extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpq2whuxta\build\youtube_dl\extractor\canvas.py", line 74, in _real_extract
KeyError: 'title'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpq2whuxta\build\youtube_dl\YoutubeDL.py", line 797, in extract_info
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpq2whuxta\build\youtube_dl\extractor\common.py", line 543, in extract
youtube_dl.utils.ExtractorError: An extractor error has occurred. (caused by KeyError('title',)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type youtube-dl -U to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Do I need to add extra commands to make this work? I just used youtube-dl.exe . Or should that work and did it break in general? Any help would be appreciated!

@thibmaek
Copy link

thibmaek commented Aug 29, 2020

@nicerman1 VRT might have changed something on their end, doesn't seem to work any longer with the current extractor implementation in youtube-dl. I was however able to download an episode by finding the link to a MPD (MPEG-DASH manifest) in a JSON response and pointing youtube-dl to that link

image

EDIT: nvm this method above works, but the issue downloading was easily fixed after logging in via youtube-dl

@nicerman1
Copy link

@nicerman1 VRT might have changed something on their end, doesn't seem to work any longer with the current extractor implementation in youtube-dl. I was however able to download an episode by finding the link to a MPD (MPEG-DASH manifest) in a JSON response and pointing youtube-dl to that link

image

EDIT: nvm this method above works, but the issue downloading was easily fixed after logging in via youtube-dl

Awesome, this works! Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants