Xsk debug qname optim #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
rec: RPZ from primary refactor and allow notifies for RPZs
rgacogne
force-pushed
the
xsk-debug-qname-optim
branch
from
2624fc3
to
4ed255e
Compare
DNSName: correct len and offset types
Signed-off-by: Y7n05h <Y7n05h@protonmail.com>
```
In file included from xsk.hh:50,
from xsk.cc:23:
In function ‘xdp_desc* xsk_ring_prod__tx_desc(xsk_ring_prod*, __u32)’,
inlined from ‘void XskSocket::send(std::vector<std::unique_ptr<XskPacket>, std::allocator<std::unique_ptr<XskPacket> > >&)’ at xsk.cc:176:28:
/usr/include/xdp/xsk.h:76:27: warning: ‘idx’ may be used uninitialized [-Wmaybe-uninitialized]
76 | return &descs[idx & tx->mask];
| ~~~~^~~~~~~~~~
```
Otherwise we might discard a valid notification between our last look at the queue and the clearing.
We cannot guarantee that the response will be coming via XSK, so we need to accept that a response that does not come from the expected socket descriptor.
rgacogne
force-pushed
the
xsk-debug-qname-optim
branch
from
4ed255e
to
94e3db7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Checklist
I have: