This repository has been archived by the owner on Jan 11, 2022. It is now read-only.
[fix] reset wrapper rectangle #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed the plugin doesn't compute the element's rectangle correctly on window resize when using the wrap feature.
The reason is the element's styles get reseted before calling
getRectanglebut the wrapper wasn't reseted what result in an incorrect computation.So the element remains small than the viewport if increase the window width after initialization.
This PR fixes it by reseting the wrapper rectangle before doing the element's rectangle computation.