Skip to content
This repository has been archived by the owner on Jan 11, 2022. It is now read-only.

[perf] scrolling #80

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 25 additions & 6 deletions src/sticky.js
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,15 @@ class Sticky {
* @param {node} element - Element for which resize events are initialised
*/
initResizeEvents(element) {
element.sticky.resizeListener = () => this.onResizeEvents(element);
let resizeTimeout;

element.sticky.resizeListener = () => {
clearTimeout(resizeTimeout);
resizeTimeout = setTimeout(() => {
this.useAF = false;
this.onResizeEvents(element);
}, 250);
};
window.addEventListener('resize', element.sticky.resizeListener);
}

Expand Down Expand Up @@ -224,6 +232,7 @@ class Sticky {
*/
onScrollEvents(element) {
if (element.sticky && element.sticky.active) {
this.useAF = true;
this.setPosition(element);
}
}
Expand Down Expand Up @@ -283,8 +292,8 @@ class Sticky {
}

this.css(element, {
top: (element.sticky.container.rect.top + element.sticky.container.offsetHeight) - (this.scrollTop + element.sticky.rect.height + element.sticky.marginBottom) + 'px' }
);
top: (element.sticky.container.rect.top + element.sticky.container.offsetHeight) - (this.scrollTop + element.sticky.rect.height + element.sticky.marginBottom) + 'px'
});
} else {
if (element.sticky.stickyClass) {
element.classList.add(element.sticky.stickyClass);
Expand Down Expand Up @@ -426,9 +435,19 @@ class Sticky {
* @param {object} properties - CSS properties that will be added/removed from specified element
*/
css(element, properties) {
for (let property in properties) {
if (properties.hasOwnProperty(property)) {
element.style[property] = properties[property];
if (this.useAF === true) {
window.requestAnimationFrame(() => {
for (let property in properties) {
if (properties.hasOwnProperty(property)) {
element.style[property] = properties[property];
}
}
});
} else {
for (let property in properties) {
if (properties.hasOwnProperty(property)) {
element.style[property] = properties[property];
}
}
}
}
Expand Down