Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #88 where antimeridian flipped sign #89

Merged
merged 1 commit into from Mar 1, 2015

Conversation

ajturner
Copy link
Contributor

Fixed issue where a point at (180,0) became (-180,0) due to an incorrect boolean inclusion test (i.e. >= 180 should be > 180)

Added two test specs

Resolves #88

teeparham added a commit that referenced this pull request Mar 1, 2015
Fixed #88 where antimeridian flipped sign
@teeparham teeparham merged commit 2f9a3a1 into rgeo:master Mar 1, 2015
@teeparham
Copy link
Member

Thank you. Yes, both 180 and -180 are valid (and equal, in fact), so we should not change either.

For future reference, please leave off the version change in PRs. Although in this case, I'll take it as a welcome hint that we need a new version. 👍

@ajturner
Copy link
Contributor Author

ajturner commented Mar 2, 2015 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating a point at the north-pole antimeridian flips the longitude
2 participants