Parse error message body on non 200 HTTP status code #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! Thanks @wcdolphin. Yep, the tests definitely aren't ideal. This was a node learning project for me, so I'm sure there are amateur mistakes in here. |
rgerard
added a commit
that referenced
this pull request
Jan 14, 2014
Parse error message body on non 200 HTTP status code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error messages appear to be served as JSON, this commit adds parsing of them.
I would add tests, but I am having a hard time reading the format of the tests. These tests would create failure conditions i.e. searching for an entity which is not found, and assert a 404 is thrown, and the body is properly deserialized.
Thanks for the useful library, saved me some time!