Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements and fix for fates-auto-params #5

Merged
merged 5 commits into from
Feb 22, 2024

Conversation

samsrabin
Copy link

@samsrabin samsrabin commented Feb 15, 2024

As discussed at ESCOMP#2336.

Improvements:

  • run_sys_tests now checks modules needed for modify_fates_paramfile for all testmods that call that in shell_commands. Required bringing in ctsm5.1.dev166.
  • Reduces code duplication in FATES testmods' shell_commands by having them use new script cime_config/testdefs/testmods_dirs/clm/_scripts/get_fates_shell_commands_vars.sh.

Fix: Create directory for file output by ncgen, if needed. That's the mkdir -p call in get_fates_shell_commands_vars.sh.

Testing
./run_sys_tests -f testlist_fates --skip-compare --skip-generate now works on both Derecho and Izumi, where testlist_fates contains:

SMS_D_Ld3.f10_f10_mg37.I2000Clm50FatesRs.MACHINE_intel.clm-Fates
SMS_D_Ld3.f10_f10_mg37.I2000Clm50FatesRs.MACHINE_intel.clm-FatesColdSeedDisp
SMS_D_Ld3.f10_f10_mg37.I2000Clm50FatesRs.MACHINE_intel.clm-FatesColdTwoStream
SMS_D_Ld3.f10_f10_mg37.I2000Clm50FatesRs.MACHINE_intel.clm-FatesColdTwoStreamNoCompFixedBioGeo

@samsrabin samsrabin changed the title Improvements and (temporary) fix for fates-auto-params Improvements and (temporary?) fix for fates-auto-params Feb 15, 2024
@samsrabin samsrabin changed the title Improvements and (temporary?) fix for fates-auto-params Improvements and fix for fates-auto-params Feb 15, 2024
@rgknox rgknox merged commit c1bd84d into rgknox:fates-auto-params Feb 22, 2024
rgknox pushed a commit that referenced this pull request May 3, 2024
glemieux pushed a commit that referenced this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants