Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rsync to sync folder with libvirt provider #7

Closed
wants to merge 1 commit into from

Conversation

roblabla
Copy link

@roblabla roblabla commented Feb 4, 2021

smb sync folder method only works on windows and MacOS host machines, according to this, causing the build to fail. Using rsync works without issues.

@rgl
Copy link
Owner

rgl commented Feb 5, 2021

I'm using it in linux too, but I have to manually apply hashicorp/vagrant#9948 (using the https://patch-diff.githubusercontent.com/raw/hashicorp/vagrant/pull/9948.patch file) to my local vagrant installation.

I still haven't gotten around for fleshing out the unit tests needed for that PR to be merged in vagrant.

The environment in this repo copies a file to the host vagrant share:

# export the CA certificate to the Vagrant project directory, so it can be used by other machines.
mkdir -Force C:\vagrant\tmp | Out-Null
dir Cert:\LocalMachine\My -DnsName $caCommonName `
| Export-Certificate -FilePath "C:\vagrant\tmp\$($caCommonName -replace ' ','').der" `
| Out-Null

That file is used by other environments (e.g. https://github.com/rgl/gitlab-vagrant), so I have to keep using SMB.

Though, I can merge the PR when you change it to be something alike: Actually this will not work... the ubuntu test node also needs to access tmp/ExampleEnterpriseRootCA.der, so this is a no go for me.

if ENV['VAGRANT_SMB_PASSWORD']
  ... smb line
else
  ... rsync line
end

@roblabla
Copy link
Author

roblabla commented Feb 5, 2021

Ah, awesome. I don't personally use the ubuntu test node, so I guess I'll keep doing this locally.

Having a bit in the README to let people know they need a custom vagrant build with hashicorp/vagrant#9948 on linux would probably be helpful ^^.

@roblabla roblabla closed this Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants