google takeout support

[vzaliva]

I want to use this script to import mbox file created via Google Takeout service. They export all mail as a single mbox file. However, each message has an additional header specifying to what folder the message belongs to. E.g:

X-Gmail-Labels: Archived,Sent

It would be great if this script can handle these.

[rgladwell]

This would be a useful enhancement, possibly behind a CLI parameter flag.

Unfortunately, I don't have much time to dedicate to this project at the moment. If you need it sooner and have time yourself, I'd be happy to give advice and review code.

[adriangibanelbtactic]

In order to avoid work overlap you should know that I am working on adding this feature in our branch: https://github.com/btactic/imap-upload/tree/google_takeout .

The current implemented functionality saves the emails in the first (or last) label/folder. Not in everyone of them as you might want to.

Note: I ported and adapted functionality from https://github.com/ldidry/gmail-mbox-to-imap which was based on an older version of imap-upload.

[rgladwell]

Fantastic! Feel free to raise a draft PR here. I'd love to see what you're doing.

[adriangibanelbtactic]

My last pull request brings Google Takeout functionaly: #35 .
Waiting for your feedback there.

Thank you.

[rgladwell]

Thanks for fixing this. Merged!

[adriangibanelbtactic]

Thanks for fixing this. Merged!

Thanks for your merge.

• Feel free to rewrite this part:

  imap-upload/imap_upload.py

  Lines 300 to 318 in 9273178

  	labels_without_categories = []
  	for i in range(len(labels)):
  	if (not (re.match(gmail_category_str,labels[i]))):
  	labels_without_categories.append(labels[i])
  	labels = labels_without_categories
  	labels_without_special_imap_dirs = []
  	for i in range(len(labels)):
  	if (not (re.match(gmail_imap_str,labels[i]))):
  	labels_without_special_imap_dirs.append(labels[i])
  	labels = labels_without_special_imap_dirs
  	sanitized_labels = []
  	for i in range(len(labels)):
  	sanitized_label = re.sub(r":", "_", labels[i])
  	sanitized_labels.append(sanitized_label)
  	labels = sanitized_labels

  in a more pythonic way (or without auxiliary list variables) if you think it's needed.

• Also this function:

  imap-upload/imap_upload.py

  Lines 590 to 600 in 9273178

  	def create_folders(self, boxes):
  	i = 1
  	while i <= len(boxes):
  	google_takeout_box = "/".join(boxes[0:i])
  	google_takeout_box_imap_command = '"' + google_takeout_box + '"'
  	if google_takeout_box != "INBOX":
  	try:
  	self.imap.create(imap_utf7.encode(google_takeout_box_imap_command))
  	except:
  	print ("Cannot create box %s" % google_takeout_box)
  	i += 1

  should be renamed from def create_folders(self, boxes): to def create_folder(self, boxpath):.

It actually doesn't deal with several folders but with one of them which can have parents in it.
And, well, you might end renaming it to create_box because what I understand as 'imap folder' you call it 'imap box' because I guess it's a more traditional way of naming it.

• This other part is not too pythonic either:

  imap-upload/imap_upload.py

  Lines 356 to 358 in 9273178

  	for i in range(len(labels)):
  	box = re.sub(r"\?", "", labels[i])
  	msg.boxes.append(box.split("/"))

  .

What I mean is that even if my code is functional it can be improved a lot by python experts.