Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the Transition events to match the svelte names #57

Closed
rgossiaux opened this issue Feb 9, 2022 · 1 comment
Closed

Rename the Transition events to match the svelte names #57

rgossiaux opened this issue Feb 9, 2022 · 1 comment
Labels
breaking change A breaking change

Comments

@rgossiaux
Copy link
Owner

When I ported these I completely forgot that Svelte has standard names for these events already: https://svelte.dev/tutorial/transition-events

We should use those event names. It's a breaking change, so I should coordinate it with the release of #47
@rgossiaux rgossiaux added the breaking change A breaking change label Feb 27, 2022
@rgossiaux rgossiaux mentioned this issue May 6, 2022
Open
@chaseweaver chaseweaver mentioned this issue May 7, 2022
Open
@rgossiaux rgossiaux mentioned this issue May 25, 2022
Merged
4 tasks
rgossiaux added a commit that referenced this issue Jun 11, 2023
@rgossiaux
Rename the Transition events to match the Svelte names
b2a6e7c 
See #57
rgossiaux added a commit that referenced this issue Jun 11, 2023
@rgossiaux
Rename the Transition events to match the Svelte names
7605c66 
See #57
rgossiaux added a commit that referenced this issue Jun 11, 2023
@rgossiaux
Rename the Transition events to match the Svelte names
9383ee3 
See #57
@rgossiaux
Copy link
Owner Author

Version 2.0.0 is now published with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change A breaking change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rgossiaux