Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portal root will be at the top of the document body if run during the initial render #78

Closed
rgossiaux opened this issue Mar 6, 2022 · 0 comments

Comments

@rgossiaux
Copy link
Owner

rgossiaux commented Mar 6, 2022

This is the exact opposite of what it's supposed to do! But if you have a static <Dialog> you can run into this.

I think it's good enough to just do a tick when initially creating the portal root, and repositioning it at the end of that tick if necessary. That should catch the most glaring cases.

We still won't guarantee that nothing else comes along and adds itself after the portal root, but that's probably desirable-- we don't want to get into a positioning war with some other element.

rgossiaux added a commit that referenced this issue Mar 7, 2022
Brain fart when writing and testing the first attempt.
I can only actually reproduce the underlying issue in the REPL so I haven't confirmed that this fixes it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant