Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test against IE 9, but allow failure #1

Closed
rgrempel opened this issue Oct 28, 2015 · 2 comments
Closed

Test against IE 9, but allow failure #1

rgrempel opened this issue Oct 28, 2015 · 2 comments

Comments

@rgrempel
Copy link
Owner

I should test against IE 9, so that the browser matrix image at the top of the README will clearly show that it's not working with IE 9. But, this is expected (at the moment), so I should not fail the whole build for that reason.

It would be nice to clearly show that IE 9 isn't working -- in other cases (Firefox, Chrome, Safari), older unlisted versions are probably working ... I just don't test all of them.
@rgrempel
Copy link
Owner Author

Fixed by c4a3a67 ... I forget to mention that in the commit message.

rgrempel added a commit that referenced this issue Oct 30, 2015
@rgrempel
Generalize a 'dontFailBuild' mechanism.
5b25c47 
For browsers that I want to show have failed, but don't want to
fail the build -- see #1.
@rgrempel
Copy link
Owner Author

rgrempel commented Nov 9, 2015

Note that I've now generalized this further, so that failing tests never fail the build from Travis-CI's point of view -- only a compiler error will fail the Travis build.

Failing tests still show up in the SauceLabs graphic as failed, though. So, that way I can distinguish between "didn't compile" and "failed on some browsers".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rgrempel