feat: support more stencil.yaml paths, generate JSON schema #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now generate JSON schema files from the Go types directly for `manifest.yaml` and `stencil.yaml`. This allows us to be able to start validating the configuration for `stencil` in editors and provide a better user experience there. Eventually, this can cascade into other schemas being supported. I also added support for `.stencil.yaml` so we can match other configuration file formats and keep it hidden (which we opt to do here now).
Deploying stencil with
|
| Latest commit: |
1146243
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://674e2ffb.stencil-1wj.pages.dev |
| Branch Preview URL: | https://jaredallard-feat-support-mor.stencil-1wj.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
deregtd
approved these changes
Jun 6, 2024
jaredallard
deleted the
jaredallard/feat/support-more-stencil-config-schema
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now generate JSON schema files from the Go types directly for
manifest.yamlandstencil.yaml. This allows us to be able to startvalidating the configuration for
stencilin editors and provide abetter user experience there. Eventually, this can cascade into other
schemas being supported.
I also added support for
.stencil.yamlso we can match otherconfiguration file formats and keep it hidden (which we opt to do here
now).