fix: Reworking dirReplacements system to work with SetPath and Blocks #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
deregtd
commented
Jun 7, 2024
deregtd
commented
- SetPath was not running through the dirreplacements system, so had to plumb things through fairly differently than before, but I like this solution much better
- Blocks were not loading properly because the path replacement was happening at the end of the process instead of during creation, so it was unable to find the file to load blocks from, and always stomped the output
* SetPath was not running through the dirreplacements system, so had to plumb things through fairly differently than before, but I like this solution much better * Blocks were not loading properly because the path replacement was happening at the end of the process instead of during creation, so it was unable to find the file to load blocks from, and always stomped the output
Deploying stencil with
|
| Latest commit: |
a9405e3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://72162dfa.stencil-1wj.pages.dev |
| Branch Preview URL: | https://ddr-betterdirreplace.stencil-1wj.pages.dev |
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
jaredallard
reviewed
Jun 8, 2024
Co-authored-by: Jared Allard <jaredallard@users.noreply.github.com>
jaredallard
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.