Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add enhancement reroute #17

Closed
pvp-by opened this issue Sep 12, 2023 · 2 comments
Closed

add enhancement reroute #17

pvp-by opened this issue Sep 12, 2023 · 2 comments

Comments

@pvp-by
Copy link

pvp-by commented Sep 12, 2023

add the possibility to use resizing like in standard ComfyUI, by placing the cursor to the bottom right corner of the node and resize it by dragging and dropping.
and in your implementation there are no additional menus :
image
as well as a severe size limitation :
image

Thank you so much for your custom nodes

@rgthree
Copy link
Owner

rgthree commented Sep 14, 2023

There was good reason for no labels and no resizing at the time (specifically because labels don't show in the multi-directions the node allows), but with a bit more work we can probably add them... and Done.

There's now both a "Allow/No Resizing" menu item, and a "Show/Hide Title Label" menu item on right click (grouped with the connection layout, static sizes, etc).

titles

Unfortunately, this is only on the dev branch for now at https://github.com/rgthree/rgthree-comfy/tree/dev which has a ton more features coming but requires some optimization in comfyui itself. Once comfyanonymous/ComfyUI#1502 is fixed and/or comfyanonymous/ComfyUI#1502 is merged, then this can land in rgthree/rgthree-comfy main.

@rgthree rgthree closed this as completed Sep 14, 2023
@pvp-by
Copy link
Author

pvp-by commented Sep 20, 2023

if it is relevant, I would like to ask for 1 more point that I may not have emphasized as a good practice.

in a normal reroute you can separately enable show title and separately enable the show type label . your version is already almost perfect both in terms of functionality and end-user friendliness.

Maybe this part (show type automatically indicates the type of the connected line instead of title) is missing for full delight.

huge sps for your hard work, the major dev20 update is excellent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants