Castform / Cherrim sprites not working correctly

[Gabbyxo97]

When Cherrim / Castform are changed in their weather forme, the game displays no sprite as seen in the image. This is only (as far as I know) with Cherrim and Castform, for example Wishiwashi works fine.

[LOuroboros]

Can confirm on a branch containing the BE, the IE and the PE.
Castform's front sprite doesn't change, and its back sprite becomes invisible.
https://streamable.com/hfjwo1

EDIT: I'll test out how does Castform's form changing behaves in the BE and the PE separately too, and edit this post.
EDIT2: Expectedly, the issue comes from the pokemon_expansion branch due to the many changes in sprites and what not, I presume. I built a clean copy of it and tested Castform, and I got the same behavior shown in that streamable link above.

[ShinyDragonHunter]

Writing here to make a note of the fact that the function that handles Castform (and Cherrim) has possibly been changed

[kevinmc37]

Something similar happens with the front sprite of Deoxys Attack. It appears normally but after a second it starts flickering and then disappears. The back sprite works fine though, as well as the other deoxys forms

[ShinyDragonHunter]

Something similar happens with the front sprite of Deoxys Attack. It appears normally but after a second it starts flickering and then disappears. The back sprite works fine though, as well as the other deoxys forms

Other forms work because they’re technically not Deoxys but their own species. And the expansion recently removed the hack that handles Deoxys’ “forms”. It might be the result of that as they may have missed something.

[kevinmc37]

As I was checking all the alternative forms for my project, I've found that the front sprite of Keldeo Resolute also has the flickering problem on its animation, although when it ends, the sprite seems to look correct. The rest of alternative forms seem to work properly unless I missed something (haven't checked alolan or galar forms)

[ExpoSeed]

#1370 and #1371

[ExpoSeed]

oops castform and cherrim are not addressed in those two prs

[AsparagusEduardo]

#2145 #2143 #2144