Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted most battle preproc ifs to regular ifs #3392

Merged

Conversation

AsparagusEduardo
Copy link
Collaborator

Description

By suggestion of @SBird1337 and @mrgriffin, I converted most preproc #ifs to proper ifs.

This should make it so that:

  • It's less likely to write code that doesn't compile.
  • Potentially allow these configs to be run by the test system.

Discord contact info

AsparagusEduardo

Copy link
Collaborator

@mrgriffin mrgriffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is correct 🤞 I didn't look too hard at the changes that are (hopefully!) covered by battle tests.

Also there's quite a few examples where I think it made the code much more readable, especially the ones that were like:

-#if ...
-if (...)
+if (... && ...)
 {
   ...
 }
 else
-#endif
 {
   ...
 }

@mrgriffin mrgriffin merged commit 311224d into rh-hideout:upcoming Oct 12, 2023
1 check passed
@AsparagusEduardo AsparagusEduardo deleted the RHH/pr/upcoming/preproc branch October 12, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants