Fix HGSS pokedex preevolutions #3894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks for contributing! Bugfixes go to master rather than upcoming, so if you could rebase, that'd be very nice :) thanks! |
kaisermg5
force-pushed
the
fix_hgss_dex_preevo
branch
from
acb1316
to
d239042
Compare
|
Sorry... Now it should be ok I think. |
Bassoonian
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With all the pokemon refactoring in 1.7 there were a couple bugs introduced while searching pokemon pre-evolutions in the HGSS pokedex.
Description
When printing a pokemon's pre-evolutions there is a loop that goes through all the species to look for the pre-evos. Because of an error the loop was checking the evolution array of the species selected in the pokedex, instead of the species being looped.
Also, since now mega-evolutions are no longer stored as an evolution but as a form, the previous logic used to find a megaevolution base species was wrong. I changed the code so it now checks the form change array.
Discord contact info
mauro58