Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: #36 #37 #38 #40 #41 + Subpackages page works #39

Closed
wants to merge 9 commits into from
Closed

Fixes: #36 #37 #38 #40 #41 + Subpackages page works #39

wants to merge 9 commits into from

Conversation

boyks
Copy link
Contributor

@boyks boyks commented Aug 29, 2014

  1. Small stars near labels on import page - I think they look pretty.
  2. User won't be switched to next page until he'll provide path to existing file or directory, if doesn't exist - on click "Next button" page will not be switched and import filed will be highlighted (looks better now)
    + same highlighting works while user typing path (-> pathlib used).
  3. Subpackages works now (files from left side moves to the tree of sub-packages) - only thing I'll need a list of files that could be added to sub-packages.
  4. About importing directory - right now I can't find cool way to work it out with one button (so I came up with those two - another way was radio buttons, but later I'll figure out how to do it with one button) - just there is no standard function for doing this.

@jsilhan
Copy link
Member

jsilhan commented Aug 30, 2014

hey, you did what I wanted but that fields looks ugly aren't they? can we preserve the background and only add red border?
Now I see that only bolding text labels for required fields would be better. Red borders (with default background preferred) could be used for validation of fields according to Fedora conventions later. Sorry for change.

@jsilhan
Copy link
Member

jsilhan commented Aug 30, 2014

Also next time use one commit per issue, please.

@boyks
Copy link
Contributor Author

boyks commented Aug 31, 2014

Yeah, after I did pull request I mentioned that they don't look pretty cool. So I already remade them. Now they look a bit different way you've described (near the name of label there is a small red star), I think it looks pretty good, tomorrow I'll make pull request for it.

@boyks boyks changed the title BuildArch and mandatory fields added(fix #36)(fix #38) Fixes: #36 #37 #38 #40 #41 + Subpackages page works Aug 31, 2014
@jsilhan
Copy link
Member

jsilhan commented Sep 1, 2014

Now that border looks cool although it changes the height of field so the bottom fields are jumping. I've taken two import buttons as temporary solution. Merged, thanks.

@jsilhan jsilhan closed this Sep 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants