ARTEMIS-2116 Set text message content on producer CLI command #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit d561ca3) (cherry picked from commit ec91038) downstream: https://issues.jboss.org/browse/ENTMQBR-1699
clebertsuconic
added
Engineering Ack
QE Review Needed
and removed
Engineering Review Needed
QE Review Needed
labels
| @@ -587,6 +587,8 @@ public void testSimpleRun(String folderName) throws Exception { | |||
| assertEquals(Integer.valueOf(10), Artemis.internalExecute("consumer", "--break-on-null", "--receive-timeout", "100", "--user", "admin", "--password", "admin")); | |||
| assertEquals(Integer.valueOf(10), Artemis.internalExecute("producer", "--message-size", "500", "--message-count", "10", "--user", "admin", "--password", "admin")); | |||
| assertEquals(Integer.valueOf(10), Artemis.internalExecute("consumer", "--break-on-null", "--receive-timeout", "100", "--user", "admin", "--password", "admin")); | |||
| assertEquals(Integer.valueOf(10), Artemis.internalExecute("producer", "--message", "message", "--message-count", "10", "--user", "admin", "--password", "admin")); | |||
| assertEquals(Integer.valueOf(10), Artemis.internalExecute("consumer", "--break-on-null", "--receive-timeout", "100", "--user", "admin", "--password", "admin")); | |||
There was a problem hiding this comment.
This doesn't satisfy QE in my opinion. This method does not validate anything on the body of the message. It partially test that messages have been received, but it does not validate anything related to the body of these messages.
if we were to merge this we would need a new QE task for the product bits.
There was a problem hiding this comment.
Where do we have the other CLI commands validated? I can create a separate commit/PR that would address it in order to satisfy QE needs.
There was a problem hiding this comment.
If its fine with QE we can raise a task to add better testing in the next sprint. Oleg could possible implement a test
feuillemorte
approved these changes
Oct 12, 2018
There was a problem hiding this comment.
command:
artemis producer --message-count=10 --destination mymessage:
....
<message id="120" priority="4" expiration="0" timestamp="1539356416943" type="text" user-id="87a6a4ea-ce2f-11e8-a69b-52540023d0d3">
<properties>
<property name="__AMQ_CID" value="877ab2de-ce2f-11e8-a69b-52540023d0d3" type="simple-string"/>
<property name="_AMQ_ROUTING_TYPE" value="1" type="byte"/>
<property name="count" value="9" type="integer"/>
<property name="ThreadSent" value="Producer ActiveMQQueue[my], thread=0" type="simple-string"/>
</properties>
<body>
<![CDATA[test message: 9]]>
</body>
</message>command:
artemis producer --message-count=10 --destination my --message "Test message body here"...
<message id="376" priority="4" expiration="0" timestamp="1539362044479" type="text" user-id="a1ec7dc7-ce3c-11e8-b5ae-52540023d0d3">
<properties>
<property name="__AMQ_CID" value="a1c93e4b-ce3c-11e8-b5ae-52540023d0d3" type="simple-string"/>
<property name="_AMQ_ROUTING_TYPE" value="1" type="byte"/>
<property name="count" value="9" type="integer"/>
<property name="ThreadSent" value="Producer ActiveMQQueue[my], thread=0" type="simple-string"/>
</properties>
<body>
<![CDATA[Test message body here]]>
</body>
</message>
clebertsuconic
added a commit
that referenced
this pull request
Oct 12, 2018
|
this is merged with the script.. ./scripts/merge-PR.sh 116
git push downstream 2.6.3.jbossorg-x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit d561ca3)
(cherry picked from commit ec91038)
downstream: https://issues.jboss.org/browse/ENTMQBR-1699