ARTEMIS-2111 ManagementContext can leak #129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clebertsuconic
force-pushed
the
ENTMQBR-1878
branch
from
b6ab007
to
899d9d8
Compare
|
@rvais @michalxo There is a test for this that:
I think this is enough and would advise a qe ack. One thing I would note is why regression testing hasn't picked this up, Im assuming that you always have a management connector configured? |
|
Yes, we always have enabled JMX (in the past via artemis.profile), currently we're using connector-host & connector-port, as we use it for queue operations. Clicked the wrong button... :-) |
|
merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 744838f)
(cherry picked from commit 70a70f4)
downstream: ENTMQBR-1878