ARTEMIS-2085 - Improve validation of MDB activation config

[rpelisse]

Issue: https://issues.jboss.org/browse/JBEAP-14106
Upstream Issue: https://issues.jboss.org/browse/WFLY-11608
Already merged in upstream master (apache/activemq-artemis@39b177d) and upstream 2.6.x ( apache/activemq-artemis@fd96827)

[rpelisse]

@jbertram thanks for the access! I'll let you rebase and merge.

[clebertsuconic]

We need a cherry-pick -x from 2.6.x on this.

[rpelisse]

Darn, you are right, I've cherry pick from master. Let me fix that...

[rpelisse]

@clebertsuconic I think you meant to cherry pick the change from master to 2.6.x, but it seems you never came around it:

activemq-artemis.git (upstream-2.6.x) $ git log --grep='ARTEMIS-2085'
$

If it helps, I can do the cherry-pick and set up the PR against 2.6.x upstream. Let me know!

[andytaylor]

Hi can you cheery pick -x so we get the commit id's please

[rpelisse]

@andytaylor @clebertsuconic done!

[clebertsuconic]

@rpelisse what is the ENTMQBR?

if you create an ENTMQBR I will do the cherry-pick -x accordingly and close this one.

[clebertsuconic]

You said done.. but I don't see any difference on your commit.

[rpelisse]

@clebertsuconic Pushed into the wrong repo (of course). Now it should be correct.

Regarding the ENTMQBR, I don't think there was ever one. AFAIK, this requirements came from EAP. Do you want me to create one?

[rpelisse]

@andytaylor I've did the cherry-pick -x, can you remove the nack label? Thanks!

[rpelisse]

@andytaylor @clebertsuconic just with you: is there anything else I can for you do on this PR?

[rpelisse]

@andytaylor Is there is an other problem with this PR that justifies the engineering nack?

[rpelisse]

@andytaylor @clebertsuconic Just a friendly reminder: I'm still unclear on why this is being tagged as engineering nack (especially as the upstream changes have been merged).