ARTEMIS-2292 - Fix queue level auto-delete for topic subscription queue #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit c4fce10) NO-DOWNSTREAM-JIRA: This is a fix on a new functionality, not yet released on the product branch.
|
@andytaylor this is important to avoid future compatibility issues on the product branch. Please merge it before tagging it. |
clebertsuconic
added
the
TEST-ADDED
Additional bits missed (cherry picked from commit 0df9205) NO-DOWNSTREAM-JIRA: This is a fix on a new functionality, not yet released on the product branch.
michalxo
reviewed
Apr 3, 2019
| @@ -3160,6 +3160,14 @@ | |||
| </xsd:annotation> | |||
| </xsd:element> | |||
|
|
|||
| <xsd:element name="auto-delete-created-queues" type="xsd:boolean" default="true" maxOccurs="1" minOccurs="0"> | |||
There was a problem hiding this comment.
Shouldn't here be default="false" @clebertsuconic ?
There was a problem hiding this comment.
Works as expected anyway. I am just curious if this is not a mistake in schema.
|
All tests are passing, manually played with it a little bit, seems to be working as expected. Have only 1 comment above. Else giving it a green light. |
Adjust auto-delete defaults based on if queue autocreated (cherry picked from commit 369c429) NO-DOWNSTREAM-JIRA: This is a fix on a new functionality, not yet released on the product branch.
(cherry picked from commit 821f291) NO-DOWNSTREAM-JIRA: This is a fix on a new functionality, not yet released on the product branch.
|
merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit c4fce10)
NO-DOWNSTREAM-JIRA: This is a fix on a new functionality, not yet released on the product branch.