Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARTEMIS-2440 Connection.fail on sendBlock should be asynchronous #266

Merged
merged 2 commits into from Aug 7, 2019
Merged

ARTEMIS-2440 Connection.fail on sendBlock should be asynchronous #266

merged 2 commits into from Aug 7, 2019

Conversation

clebertsuconic
Copy link
Contributor

No description provided.

@clebertsuconic clebertsuconic added Engineering Ack QE Review Needed TEST-ADDED There is a test as part of the PR. (This could be used to help QA to make their evaluation) labels Aug 5, 2019
@rvais
Copy link

rvais commented Aug 6, 2019

I got some failures from attached tests. so for now Nack

@rvais rvais added the QE Nack label Aug 6, 2019
@clebertsuconic
Copy link
Contributor Author

@rvais this is because the test had a previous fix from @jbertram at 75a6851

I have amended the test to include the previous fix. Nothing I did wrong on this one. The fix still good.

Test ammended.. it should be good now.

@clebertsuconic
Copy link
Contributor Author

it should be fine with the last push -f I did:

Screen Shot 2019-08-06 at 2 21 04 PM

@clebertsuconic
ARTEMIS-2440 Connection.fail on sendBlock should be asynchronous
4372d23 
This is following up on ARTEMIS-2327.

(cherry picked from commit cd723aa)

downstream: ENTMQBR-2720
@clebertsuconic
ARTEMIS-2440 Call timeout should retry the connection asynchronously
d5e37e5 
(cherry picked from commit 205a139)

downstream: ENTMQBR-2720
@rvais
Copy link

rvais commented Aug 7, 2019

Test's have now passed.

@franz1981 franz1981 merged commit d5e37e5 into rh-messaging:2.9.0.jbossorg-x Aug 7, 2019
franz1981 added a commit that referenced this pull request Aug 7, 2019
@franz1981
This is PR #266 ARTEMIS-2440 Connection.fail on sendBlock should be a…
e3da430 
…synchronous
@clebertsuconic clebertsuconic deleted the ENTMQBR-2720 branch August 7, 2019 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Engineering Ack QE Ack TEST-ADDED There is a test as part of the PR. (This could be used to help QA to make their evaluation)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@clebertsuconic @rvais @franz1981