New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paging Fixes #267
Merged
clebertsuconic
merged 6 commits into
rh-messaging:2.9.0.jbossorg-x
from
clebertsuconic:ENTMQBR-2730
Aug 6, 2019
Merged
Paging Fixes #267
clebertsuconic
merged 6 commits into
rh-messaging:2.9.0.jbossorg-x
from
clebertsuconic:ENTMQBR-2730
Aug 6, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit fa46647) downstream: ENTMQBR-2730
(cherry picked from commit 99158cc) downstream: ENTMQBR-2730
(cherry picked from commit b92cde1) downstream: ENTMQBR-2730
(cherry picked from commit dd62be1) downstream: ENTMQBR-2730
(cherry picked from commit edace88) downstream: ENTMQBR-2730
clebertsuconic
added
Engineering Review Needed
QE Review Needed
TEST-ADDED
There is a test as part of the PR. (This could be used to help QA to make their evaluation)
labels
Aug 5, 2019
It's impossible to bring these fixes in separate PRs. @franz1981 if you could also please review I'm not missing any other commit. |
franz1981
approved these changes
Aug 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
clebertsuconic
force-pushed
the
ENTMQBR-2730
branch
from
August 6, 2019 15:13
c666bcf
to
fcff849
Compare
(cherry picked from commit aa5d76e) downstream: ENTMQBR-2730
franz1981
approved these changes
Aug 6, 2019
michalxo
added
Customer Issue
Whether this issue originates from customer (higher importance)
Metadata-added
Test case metadata in description of issue is provided
labels
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Customer Issue
Whether this issue originates from customer (higher importance)
Engineering Ack
Metadata-added
Test case metadata in description of issue is provided
QE Ack
TEST-ADDED
There is a test as part of the PR. (This could be used to help QA to make their evaluation)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
downstream: ENTMQBR-2730
test: org.apache.activemq.artemis.tests.extras.byteman.RaceOnCursorIteratorTest#testSkipLivePageCache,org.apache.activemq.artemis.tests.extras.byteman.RaceOnCursorIteratorTest#testSkipNullPageCache,org.apache.activemq.artemis.tests.integration.client.LargeMessageTest#testLargeMessageBodySize,org.apache.activemq.artemis.tests.integration.largemessage.ServerLargeMessageTest#testSendServerMessage,org.apache.activemq.artemis.tests.integration.paging.PagingTest#testPageEmptyFile,org.apache.activemq.artemis.tests.integration.paging.PagingTest#testLivePageCacheEvicted,org.apache.activemq.artemis.tests.integration.persistence.XmlImportExportTest#testLargeMessage,org.apache.activemq.artemis.tests.integration.server.ScaleDown3NodeTest#testBasicScaleDownInternal,org.apache.activemq.artemis.tests.unit.core.paging.impl.PageTest#testAdd,org.apache.activemq.artemis.tests.unit.core.paging.impl.PagingManagerImplTest#testPagingManager,org.apache.activemq.artemis.tests.unit.core.paging.impl.PagingStoreImplTest#testDepageMultiplePages,org.apache.activemq.artemis.tests.unit.core.paging.impl.PagingStoreImplTest#testWriteIncompletePage
component: Artemis
subcomponent: message_delivery
level: component
importance: medium
type: functional
subtype: compliance
verifies: AMQ-90