ARTEMIS-2451 eliminate knownDestinations cache #275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clebertsuconic
added
Engineering Ack
QE Review Needed
TEST-ADDED
|
Can't build it: |
|
fixed it |
|
@mkrutov at the time I sent this I didn't know how to build downstream properly on my local computer... which I know how to do it now.. I built locally and it worked |
|
Still not buildable. |
clebertsuconic
force-pushed
the
ENTMQBR-2759
branch
from
98a4e0e
to
0b2db97
Compare
|
@mkrutov I pushed it to my open source fork. did it again and it at the correct fork now. |
mkrutov
approved these changes
Sep 6, 2019
| import org.apache.activemq.artemis.jms.client.ActiveMQQueue; | ||
| import org.apache.activemq.artemis.jms.client.ActiveMQTemporaryTopic; | ||
| import org.apache.activemq.artemis.jms.client.ActiveMQTopic; | ||
| import org.apache.activemq.artemis.junit.Wait; | ||
| import org.apache.activemq.artemis.spi.core.security.ActiveMQJAASSecurityManager; | ||
| import org.apache.activemq.artemis.tests.integration.IntegrationTestLogger; | ||
| import org.apache.activemq.artemis.tests.util.JMSTestBase; | ||
| import org.apache.activemq.artemis.tests.util.Wait; |
There was a problem hiding this comment.
You need to rename Wait class to something else or use full class path+class name (org.apache.activemq.artemis.tests.util.Wait); otherwise you have another Wait imported 4 lines above it and it fails to build because of that.
|
merged it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.