Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENTMQBR-4610 Asynchronous close of files #452

Closed
wants to merge 9 commits into from
Closed

ENTMQBR-4610 Asynchronous close of files #452

wants to merge 9 commits into from

Conversation

clebertsuconic
Copy link
Contributor

This is pretty much getting rid of the issue on Timeout on close.

Whatever the issue, there's no more blocking on moving to a new file. if the issue is on customer's environments (due to slow IO) or a non identified bug, this will fix it regardless.

@clebertsuconic
ARTEMIS-3084 Eliminate Block on moving to next file on libaio
7700c3b 
(cherry picked from commit c019218)

downstream: ENTMQBR-4610
@clebertsuconic
ARTEMIS-3084 Small tweak. Log a Thread dump if a server.stop cannot g…
75a8eeb 
…et a completion of pending closes

(cherry picked from commit 03f8f83)

downstream: ENTMQBR-4610
@clebertsuconic
ARTEMIS-3084 Fixing intermittent failures on testsuite. file.close() …
179fda1 
…should block

This fixed a failure I saw once at GroupingFailoverReplicationTest.testGroupingLocalHandlerFailsMultipleGroups

(cherry picked from commit 4b5c299)

downstream: ENTMQBR-4610
@clebertsuconic
ARTEMIS-3084 Avoiding Race condition on async close
6bad59a 
(cherry picked from commit 873c2bc)

downstream: ENTMQBR-4610
@clebertsuconic
ARTEMIS-3084 Fix on checkstyle
b194c8a 
sorry for breaking it in the first place.
I messed up into some gitfu sending an older version by accident.

(cherry picked from commit 7ce5315)

downstream: ENTMQBR-4610
@clebertsuconic
ARTEMIS-3084 Issue a warning instead of blocking forever in case of n…
077fcd2 
…ot completing closes

(cherry picked from commit b05bea7)

downstream: ENTMQBR-4610
@clebertsuconic
ARTEMIS-3084 Issue a warning instead of blocking forever in case of n…
9931f24 
…ot completing closes

(cherry picked from commit 03b0fcd)

downstream: ENTMQBR-4610
@clebertsuconic clebertsuconic added LTS Long term support QE Review Needed labels Feb 1, 2021
@clebertsuconic
ARTEMIS-3084 Deal with async close and double close
51ea18b 
Since the libaio.close is now async
there might be a situation with more than one close called during a server.stop();

This should deal with that scenario

(cherry picked from commit 755947e)

downstream: ENTMQBR-4610
@clebertsuconic
ARTEMIS-3084 Avoid pending IO to close files
5abe766 
(cherry picked from commit c47122e)

downstream: ENTMQBR-4610
@brusdev brusdev added LTS-7.8 and removed LTS Long term support labels Mar 4, 2021
@feuillemorte feuillemorte self-requested a review March 22, 2021 09:45
@feuillemorte
Copy link
Contributor

There are 587 failures of unittests. Please, check the results that there are no unexpected failures

https://amq-broker-jenkins-csb-messaging-qe.cloud.paas.psi.redhat.com/job/amq-broker-7/job/midstream/job/upstream-test-suite/job/upstream-test-suite/48/testReport/

brusdev added a commit that referenced this pull request Apr 1, 2021
@brusdev
This is PR #452
bb547e4
@brusdev
Copy link
Contributor

brusdev commented Apr 1, 2021

merged

@brusdev brusdev closed this Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feuillemorte feuillemorte feuillemorte approved these changes

Assignees
No one assigned
Labels
LTS-7.8 QE Ack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@clebertsuconic @feuillemorte @brusdev