JBEAP-6170 messages could be sent to wrong queue

[treblereel]

In rare circumstances MessageProducer can send a message
to wrong queue

JIRA: https://issues.apache.org/jira/browse/ARTEMIS-715
https://issues.jboss.org/browse/JBEAP-6170

(cherry picked from commit 62f90ea)

[dudaerich]

Hi, I reviewed your change and I think that it is not correct. Imagine a following scenario:

MessageProducer producer = session.createProducer(queueA);
producer.send(queueB, msg);

1. Producer is created with default queue queueA => ClientProducerImpl.address = queueA
2. Producer send message to queueB => ClientProducerImpl.doSend(queueB, msg, ...)
3. In method ClientProducerImpl.sendRegularMessage
   1. session.checkDefaultAddress(address) => default address on client side is queueA
   2. the very first message is sent to queueB so server set the default address to queueB
   3. default addresses on client and server are different => error

In the original fix on HornetQ the sendingAddress from doSend method is passed to session.checkDefaultAddress not ClientProducerImpl.address.

[andytaylor]

@dudaerich are you saying the upstream fix is wrong or it has been cherry picked incorrectly?

[andytaylor]

Also the EAP Jira needs to be added to the commit mesage

[dudaerich]

@andytaylor the upstream fix is wrong as well.

[treblereel]

@dudaerich my fault, is it better ?

[andytaylor]

Then it needs fixing upstream and both fixes cherry-picked

[dudaerich]

@treblereel yes, it looks good now.

[treblereel]

@dudaerich done, apache#781

[treblereel]

retest this please

[dudaerich]

Tests passed.

[mtaylor]

@treblereel can you please ensure that you have included the upstream JIRA, the cherry-pick commit and the downstream JBEAP-XXXX. In the "commit message" not just the PR message.

The JBEAP referenced in the PR has been closed. Is this the correct one: https://issues.jboss.org/browse/JBEAP-6170

[treblereel]

@mtaylor today is a public holiday, may i check it tomorrow ?

[mtaylor]

@treblereel yes of course. Enjoy!

[treblereel]

@mtaylor sorry for delay, i think, it happens, because i did this PR before QA did JBEAP-6065 (new scenario), maybe it's better to change reference from JBEAP-4721 to JBEAP-6065, is case 4721 already verified.

ps. i have to check which branch is used for 7.1 ...

[wolfc]

It should be enough to have all links correctly in the PR description. Retro-fitting commit messages is very much a pain.

• JBEAP-6065 is a 7.1.0 issue. This needs to be linked to a 7.0.x issue.

[mtaylor]

@wolfc I don't know what you mean re: "retro fitting a commit message is very much a pain". During the cherry-pick just add the JBEAP JIRA and information required. To fix it (if someone forgot) git rebase -i and a rename. The whole process takes less that a minute and it makes it easier for us to track which commits align to particular JIRAs.