Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JBEAP-6196 ARTEMIS-734 Message expired while being moved on the clust… #165

Merged
merged 1 commit into from
Mar 23, 2017
Merged

JBEAP-6196 ARTEMIS-734 Message expired while being moved on the clust… #165

merged 1 commit into from
Mar 23, 2017

Conversation

soul2zimate
Copy link

…er bridge does not follow the address setting configuration.

(cherry picked from commit 2509eeb)

This is for 7.0.z issue https://issues.jboss.org/browse/JBEAP-6196

The previous #120 is incomplete. See History for QueueImpl.java at https://github.com/rh-messaging/jboss-activemq-artemis/commits/jboss-1.1.0-x/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java Commits on Sep 28, 2016. The actual commit content e5696ea is different than 2509eeb from jboss-1.5.3-x branch.
It seems that the real commit has been changed for some reason in cherry-pick.

…er bridge does not follow the address setting configuration.

(cherry picked from commit 2509eeb)
@soul2zimate
Copy link
Author

Can someone review this? This one is identified as part of 7.0.6 payload.

@soul2zimate
Copy link
Author

@mtaylor @clebertsuconic We have the component freeze for EAP 7.0.6 on Mar-24 Fri. Please let us know what is needed to move this forward, thanks.

@mtaylor
Copy link

mtaylor commented Mar 23, 2017

There were 4 commits associated with the JIRA outlined in the commit message. Some improvements and tests were added. These will need to be cherry-picked as well. Leave it with me, I'll do the necessary bits.

@soul2zimate
Copy link
Author

Do you mean #120 ?
It's been merged, but very strange, this one missed last time.

@mtaylor
Copy link

mtaylor commented Mar 23, 2017

@clebertsuconic Yes I meant the same commits from #120 actually there should be 3 commits as one does not apply.

@mtaylor
Copy link

mtaylor commented Mar 23, 2017

@soul2zimate I am a little confused here, I can see: e5696ea

Which is a commit with the exact same title as the one here, but with a different diff. Is the purpose of this pull request to modify the original commit (was there some issue with cherry-pick/conflict resolution in the original cherry-pick?)

@soul2zimate
Copy link
Author

It seems it has been modified for some reason last time, But I can not figure out why this strangely happened in #120
As you see e5696ea said "cherry picked from commit 2509eeb" But it's totally different content. That's why https://issues.jboss.org/browse/JBEAP-6196 is reopened in last CP, because the fix in incomplete.

@mtaylor
Copy link

mtaylor commented Mar 23, 2017

@soul2zimate I suspect there were some merge conflicts and this was modified.

@mtaylor mtaylor merged commit a940194 into rh-messaging:jboss-1.1.0-x Mar 23, 2017
@soul2zimate soul2zimate deleted the JBEAP-6196-1.1.0-X branch July 27, 2017 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants