Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The sync feature flag is not compatible with no_std #867

Closed
roeeshoshani opened this issue May 1, 2024 · 1 comment · Fixed by #874
Closed

The sync feature flag is not compatible with no_std #867

roeeshoshani opened this issue May 1, 2024 · 1 comment · Fixed by #874
Labels

Comments

@roeeshoshani
Copy link

when i enable both the sync and the no_std feature flags, rhai won't compile due to using std::sync::RwLock, which is not provided by the no-std-compat crate due to not using the compat_sync feature flag of that crate.

this can simply be solved by enabling the compat_sync feature flag of the no-std-compat crate.

@schungx schungx added the bug label May 1, 2024
@schungx
Copy link
Collaborator

schungx commented May 1, 2024

Ah, thanks for this. Will you make a PR? Or I can do it.

@misssonder misssonder mentioned this issue May 14, 2024
schungx added a commit that referenced this issue May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants