dotobject.Object function

[v1d3rm3]

Object.keys(obj).forEach(function (k) {
         ^
TypeError: Cannot convert undefined or null to object

I think it'll be good if there was a filter to undefined and null objects in this function, i looked at the code, but there wasn't a filter.

[rhalff]

If you would like type checking like that you could consider using typescript.

Somebody made a definition available at: https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/dot-object

Although I do notice the types there should be updated, because the argument type is currently defined there as any which really should be an object.

Perhaps I'll do a pull request there later, however I'm not really using typescript at the moment.

[v1d3rm3]

Hi, @rhalff. But, i think is not a problem with the Typescript. I'm using the type definition. Like i said, it's just a definition of a behavior to dotobject.object(obj), when obj is null or undefined. Actually, the library is giving an error of nullor undefined. I think you just need to define a standard behavior, example:

DotObject.prototype.object = function (obj, mods) {
  var self = this

  // HERE COMES THE FILTER EXAMPLE
  // I think if it's null or undefined, just return undefined
  if (!obj) { // or, more readable, if (obj === null || obj === undefined)
    return undefined;
  }

  Object.keys(obj).forEach(function (k) {
    var mod = mods === undefined ? null : mods[k]
    // normalize array notation.
    var ok = parsePath(k, self.seperator).join(self.seperator)

    if (ok.indexOf(self.seperator) !== -1) {
      self._fill(ok.split(self.seperator), obj, obj[k], mod)
      delete obj[k]
    } else if (self.override) {
      obj[k] = _process(obj[k], mod)
    }
  })

  return obj
}

[rhalff]

I think updating the type definition would be enough else every single function should always test the type of each and every argument during runtime.

If in your code obj could be undefined or null you should test it before making a call to .object