Fix ecliptic to equatorial epoch #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, when a set of ecliptic coordinates was converted to equatorial ones, the given epoch was broken. Now, it is possible to convert properly ecliptic coordinates for an epoch, to equatorial coordinates for another epoch. It is possible that this work will be improved with a more accurate algorithm from jean Meeus, in the future.
rhannequin
added a commit
that referenced
this pull request
Apr 29, 2024
## What's Changed _If you are upgrading: please see [UPGRADING.md]._ [UPGRADING.md]: https://github.com/rhannequin/astronoby/blob/main/UPGRADING.md ### Bug fixes * Fix ecliptic to equatorial epoch ([#56]) [#56]: #56 ### Features * Add twilight times ([#49]) * Add interpolation method ([#52]) * Add decimal_hour_to_time util ([#53]) * Calculate leap seconds for an instant ([#54]) * Add `Angle#-@` ([#55]) * Enable equivalence and hash equality to `Observer` ([#57]) * Twilight events dedicated class ([#61]) [#49]: #49 [#52]: #52 [#53]: #53 [#54]: #54 [#55]: #55 [#57]: #57 [#61]: #61 ### Improvements * Upgrade bundler from 2.3.11 to 2.5.7 by @dorianmariecom ([#45]) * Drop `BigDecimal` ([#46]) * Bump rake from 13.1.0 to 13.2.0 ([#47]) * Increase Ruby versions support ([#48]) * Bump rake from 13.2.0 to 13.2.1 ([#51]) * Dedicated constants class ([#62]) * Improve accuracy of equation of time ([#63]) * Twilight times better accuracy ([#65]) * Update UPGRADING.md ([#66]) * release: Bump version to 0.4.0 ([#67]) [#45]: #45 [#46]: #46 [#47]: #47 [#48]: #48 [#51]: #51 [#62]: #62 [#63]: #63 [#65]: #65 [#66]: #66 [#67]: #67 ### Backward-incompatible changes * More accurate rising, transit and setting times ([#50]) * Observation events dedicated and centralized class ([#60]) * Change `Astronoby::Sun` constructor ([#64]) [#50]: #50 [#60]: #60 [#64]: #64 ## New Contributors * @dorianmariecom made their first contribution in [#45] [#45]: #45 **Full Changelog**: v0.3.0...v0.4.0
rhannequin
added a commit
that referenced
this pull request
Apr 29, 2024
## What's Changed _If you are upgrading: please see [UPGRADING.md]._ [UPGRADING.md]: https://github.com/rhannequin/astronoby/blob/main/UPGRADING.md ### Bug fixes * Fix ecliptic to equatorial epoch ([#56]) [#56]: #56 ### Features * Add twilight times ([#49]) * Add interpolation method ([#52]) * Add decimal_hour_to_time util ([#53]) * Calculate leap seconds for an instant ([#54]) * Add `Angle#-@` ([#55]) * Enable equivalence and hash equality to `Observer` ([#57]) * Twilight events dedicated class ([#61]) [#49]: #49 [#52]: #52 [#53]: #53 [#54]: #54 [#55]: #55 [#57]: #57 [#61]: #61 ### Improvements * Upgrade bundler from 2.3.11 to 2.5.7 by @dorianmariecom ([#45]) * Drop `BigDecimal` ([#46]) * Bump rake from 13.1.0 to 13.2.0 ([#47]) * Increase Ruby versions support ([#48]) * Bump rake from 13.2.0 to 13.2.1 ([#51]) * Dedicated constants class ([#62]) * Improve accuracy of equation of time ([#63]) * Twilight times better accuracy ([#65]) * Update UPGRADING.md ([#66]) * release: Bump version to 0.4.0 ([#67]) [#45]: #45 [#46]: #46 [#47]: #47 [#48]: #48 [#51]: #51 [#62]: #62 [#63]: #63 [#65]: #65 [#66]: #66 [#67]: #67 ### Backward-incompatible changes * More accurate rising, transit and setting times ([#50]) * Observation events dedicated and centralized class ([#60]) * Change `Astronoby::Sun` constructor ([#64]) [#50]: #50 [#60]: #60 [#64]: #64 ## New Contributors * @dorianmariecom made their first contribution in [#45] [#45]: #45 **Full Changelog**: v0.3.0...v0.4.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, when a set of ecliptic coordinates was converted to equatorial ones, the given epoch was broken.
Now, it is possible to convert properly ecliptic coordinates for an epoch, to equatorial coordinates for another epoch.
It is possible that this work will be improved with a more accurate algorithm from jean Meeus, in the future.