Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total Level compatibility with genMDM Editor #26

Closed
2xAA opened this issue Sep 29, 2021 · 4 comments
Closed

Total Level compatibility with genMDM Editor #26

2xAA opened this issue Sep 29, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@2xAA
Copy link

2xAA commented Sep 29, 2021

Hey,

This is fantastic work!
I've been working on an editor for genMDM (https://github.com/2xAA/genmdm-editor) and I just picked up an Everdrive to try this project out.

Checking compatibility with my editor and it seems the Total Level CCs are being interpreted as 127-0 when they should be inverted for genMDM compatibility (0 being quietest and 127 being loudest).

I'm not sure if you'd be willing to invert the CC at this stage in the project, but maybe adding a genMDM compatibility flag somewhere in SysEx might be a neat solution?

Looking forward to your reply,
Sam

P.S. - I'm also in London, usually free if you wanna chat chiptune/music/code!

@rhargreaves
Copy link
Owner

Sounds like a sensible option to have; I'll look into it!

rhargreaves added a commit that referenced this issue Oct 2, 2021
Enabling this option emulates the GenMDM behaviour of inverting the total level before sending it to the YM2612. Note that the on-screen parameters display will show the actual register value sent to the YM2612, rather than the flipped MIDI CC value (so will be inverted to what GenMDM/MIDI says it should be)
(#26)
@rhargreaves
Copy link
Owner

New SysEx command released in v1.7

@2xAA
Copy link
Author

2xAA commented Oct 4, 2021

@rhargreaves Thank you so much, this works perfectly.

Could I suggest updating the SysEx page to display the numbers in "full" hex notation? (e.g. 0x00 0x22 0x77 0x07 0xXX)

I was a bit confused why my decimals weren't working until I looked at the first SysEx command on the page and realised my mistake as none of the other SysEx commands have any hex-specific characters.

@rhargreaves
Copy link
Owner

Good suggestion! I've clarified that the column of SysEx codes should be read in hexadecimal. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants