Update to use vertx 1.1.0.final #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Awesome. I will merge this as soon as possible, probably will be end of the week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HI there, the old class to start Vertx via CLI is gone and has been replaced with something called Starter in vertx 1.1.0.final. I needed this because I just updated to 1.1.0.final.
Careful with the pom changes, I used slightly different names for my deployed vertx stuff than you did. Really the only change you need is in src/main/java/org/vertx/maven/plugin/VertxServer.java.
Thanks, by the way, for starting this project, it makes the pom much nicer looking than trying to use java:exec.
Cheers!