Upgrade Gradle to 5.6.4 #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I upgraded shadow to 5.10 because i saw that it adds support to gradle5 in later versions |
ZacSweers
reviewed
Nov 3, 2019
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-5.6.4-bin.zip |
There was a problem hiding this comment.
Can you please keep this as all?
ZacSweers
approved these changes
Nov 3, 2019
|
Please let me know if something is needed from my side. Squashing is possible from github now so i guess i won't need to rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My intellij died when working with gradle 4.10.
Soon gradle 6 will come out so this is quite ancient.
I tried to run all tasks except the publish task and they finished successfully.