Fix Parcelable Creator logic (deserializer) for List and Parcelable#140
Closed
eonj wants to merge 1 commit into
Closed
Fix Parcelable Creator logic (deserializer) for List and Parcelable#140eonj wants to merge 1 commit into
eonj wants to merge 1 commit into
Conversation
Owner
Author
|
@rharter Thank you, I read #112 changes and got it: you're right this PR is not sufficiently caring about the type wildcard or My question is: do you have any plans for make right generic support again for the possible cases; or can you give me any instructions for alternative solution for correct generation? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After some months using this helpful AutoValue Parcel extension, I found that the current implementation is unparcelizing generic-typed fields in an inappropriate way. When a AutoValue declared class type
Acontains a field typedList<B>, The generatedcreateFromParcelusesreadArrayListwithClassLoaderof typeA-- notB.I tried to fix this problem in more broad and generous way -- for example, can we fix it with the map? Can we show an informatic message to the user when the type parameter is not a concrete bound but a
extends Tor asuper T? Can we just warn the user instead of blowingjavacwith an unhandledAutoValueParcelException?But I failed because I cannot read and change the whole code, so I submit a patch currently used (by my team). Thank you.