Bugfix: Avoid dot notation in minified Javascript #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is better to use `[]` for object access in Javascript code that is processed by Emscripten. The Javascript libraries passed to emcc are being minified with Google's [Closure Compiler](https://developers.google.com/closure/compiler) due to the `--closure 1` parameter. The closure compiler minifies keys on objects. ```js const mxPathName = vfs.mxPathName ?? 64; ``` is minified as ```js var n=h.Lg??64; ``` where `h.Lg` is undefined, so `n` will always be `64`. With this change, the minified output is ```js var n=h.mxPathName??64; ```
|
Ah, good catch! Thanks! |
|
@rhashimoto Any plans for a new release? |
|
@joeyates I'll cut one soon. There's one more thing I want to include. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is better to use
[]for object access in Javascript code that is processed by Emscripten.The Javascript libraries passed to emcc are being minified with Google's Closure
Compiler due to the
--closure 1parameter.The closure compiler minifies keys on objects.
is minified as
where
h.Lgis undefined, sonwill always be64.With this change, the minified output is
Checklist
non-exclusive, royalty-free, irrevocable copyright license to reproduce, prepare
derivative works of, publicly display, sublicense, and distribute this
Contribution and such derivative works.
Contribution contains no content requiring a license from any third party.