Skip to content

Commit

Permalink
Install podman-systemd.unit man page, make quadlet discoverable
Browse files Browse the repository at this point in the history
Currently we are shipping no data about quadlet, since the
podman-systemd.unit file is not shipped. Also want to add the
quadlet name to the description of the man page so that

man -k quadlet

will help users find the man page.

Also add a link file such that if the user types in
man quadlet
man will show the podman-systemd.unit file.

Also eliminate the subpackage podman-quadlet

Fixes: containers#17349

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
  • Loading branch information
rhatdan committed Feb 3, 2023
1 parent d8ef86a commit dc160af
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 18 deletions.
3 changes: 3 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -839,8 +839,11 @@ install.modules-load: # This should only be used by distros which might use ipta
.PHONY: install.man
install.man:
install ${SELINUXOPT} -d -m 755 $(DESTDIR)$(MANDIR)/man1
install ${SELINUXOPT} -d -m 755 $(DESTDIR)$(MANDIR)/man5
install ${SELINUXOPT} -m 644 $(filter %.1,$(MANPAGES_DEST)) $(DESTDIR)$(MANDIR)/man1
install ${SELINUXOPT} -m 644 docs/source/markdown/links/*1 $(DESTDIR)$(MANDIR)/man1
install ${SELINUXOPT} -m 644 $(filter %.5,$(MANPAGES_DEST)) $(DESTDIR)$(MANDIR)/man5
install ${SELINUXOPT} -m 644 docs/source/markdown/links/*5 $(DESTDIR)$(MANDIR)/man5

.PHONY: install.completions
install.completions:
Expand Down
1 change: 1 addition & 0 deletions docs/source/markdown/links/quadlet.5
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
.so man5/podman-systemd.unit.5
2 changes: 1 addition & 1 deletion docs/source/markdown/podman-systemd.unit.5.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## NAME

podman\-systemd.unit - systemd units using Podman
podman\-systemd.unit - systemd units using Podman quadlet

## SYNOPSIS

Expand Down
23 changes: 6 additions & 17 deletions podman.spec.rpkg
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ Requires: iptables
Requires: nftables
Recommends: catatonit
Suggests: qemu-user-static
Conflicts: quadlet

# More detailed description of the package
%description
Expand Down Expand Up @@ -141,17 +142,6 @@ Remote client for managing %{name} containers.
manage pods, containers and container images. %{name}-remote supports ssh
connections as well.

%package quadlet
Summary: Easily create systemd services using %{name}
Requires: %{name} = %{epoch}:%{version}-%{release}
Conflicts: quadlet

%description quadlet
This package installs a systemd generator for *.container files in
/etc/containers/systemd. Such files are automatically converted into
systemd service units, allowing easily written and maintained
podman-based system services.

# The following four sections already describe the rpm build process itself.
# prep will extract the tarball defined as Source above and descend into it.
%prep
Expand Down Expand Up @@ -240,6 +230,9 @@ fi
%{_bindir}/%{name}
%dir %{_libexecdir}/%{name}
%{_libexecdir}/%{name}/rootlessport
%{_libexecdir}/%{name}/quadlet
%_prefix/lib/systemd/system-generators/podman-system-generator
%_prefix/lib/systemd/user-generators/podman-user-generator
%{_datadir}/bash-completion/completions/%{name}
# By "owning" the site-functions dir, we don't need to Require zsh
%dir %{_datadir}/zsh/site-functions
Expand All @@ -261,6 +254,8 @@ fi
%{_userunitdir}/%{name}-kube@.service
%{_tmpfilesdir}/%{name}.conf
%{_user_tmpfilesdir}/%{name}-docker.conf
%{_mandir}/man5/quadlet*.5*
%{_mandir}/man5/podman-systemd.unit*.5*
%if 0%{?fedora} >= 36
%{_modulesloaddir}/%{name}-iptables.conf
%endif
Expand All @@ -271,12 +266,6 @@ fi
%{_mandir}/man5/docker*.5*
%{_usr}/lib/tmpfiles.d/%{name}-docker.conf

%files quadlet
%license LICENSE
%{_libexecdir}/%{name}/quadlet
%_prefix/lib/systemd/system-generators/podman-system-generator
%_prefix/lib/systemd/user-generators/podman-user-generator

%files remote
%license LICENSE
%{_bindir}/%{name}-remote
Expand Down

0 comments on commit dc160af

Please sign in to comment.