Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Py3.9 + Django3.2, Drop Py3.5 #159

Merged
merged 2 commits into from Apr 13, 2021
Merged

Support Py3.9 + Django3.2, Drop Py3.5 #159

merged 2 commits into from Apr 13, 2021

Conversation

alexandredufour
Copy link
Contributor

@alexandredufour alexandredufour commented Apr 12, 2021 •
edited

Add support for Django 3.2.X
Add test matrix for Django 3.2.X

Add support for Python 3.9.X
Add test matrix for Python 3.9.X

Drop support for Python 3.5.X

Increment version => 1.8.10

Travis => https://travis-ci.org/github/rhblind/drf-haystack/builds/766795914

@alexandredufour alexandredufour changed the title Support Py3.9 + Django3.2, Drop Py3.5 [WIP] - Support Py3.9 + Django3.2, Drop Py3.5 Apr 12, 2021
@alexandredufour alexandredufour marked this pull request as ready for review April 12, 2021 15:06
@coveralls
Copy link

coveralls commented Apr 12, 2021 •
edited

Coverage Status

Coverage remained the same at 88.606% when pulling 88a7f54 on PokaInc:feature/add-python39-and-django32 into e34394f on rhblind:master.

alexandredufour
alexandredufour commented Apr 12, 2021
View reviewed changes
tox.ini
Comment on lines -22 to -23
py36-django3.1-es1.x,
py36-django3.1-es2.x,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two never tested with py37

alexandredufour
alexandredufour commented Apr 12, 2021
View reviewed changes
tox.ini
Comment on lines -29 to -30
py36-django3.1-es1.x,
py36-django3.1-es2.x,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two never tested with py38

alexandredufour
alexandredufour commented Apr 12, 2021
View reviewed changes
tox.ini
Comment on lines +35 to +42
py39-django2.2-es1.x,
py39-django2.2-es2.x,
py39-django3.0-es1.x,
py39-django3.0-es2.x,
py39-django3.1-es1.x,
py39-django3.1-es2.x,
py39-django3.2-es1.x,
py39-django3.2-es2.x,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Py39

@alexandredufour alexandredufour changed the title [WIP] - Support Py3.9 + Django3.2, Drop Py3.5 Support Py3.9 + Django3.2, Drop Py3.5 Apr 12, 2021
@rhblind rhblind merged commit 6ff951b into rhblind:master Apr 13, 2021
@alexandredufour
Copy link
Contributor Author

@rhblind
Thanks for the quick merge.
Do you think it would be possible to create the 1.8.10 release in pypi ?

@rhblind
Copy link
Owner

rhblind commented Apr 13, 2021

Beautiful, thanks!
Yes, I'll try to get it done within a few days :)

@jgadelange
Copy link
Contributor

Any update on the ETA? (preferably also a release with #160 👼 )
Or should I for now add a git install line to my requirements.txt?

@rhblind
Copy link
Owner

rhblind commented May 4, 2021

Hey,
I'm sorry, I got caught up in work. I'll put it in my calendar and make a release before the weekend!

@rhblind
Copy link
Owner

rhblind commented May 4, 2021

Hello,
I really appreciate the work you guys do to help me keeping this project somewhat still relevant, and I'm sorry for being slow to merge and respond to your PRs. But anyways, thank you very much ♥️

Just pushed the new version to PyPi now!

And, by the way, if anybody wants to help maintaining the library, please shout out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alexandredufour @coveralls @rhblind @jgadelange