Avoid format error on i686 #211
Merged
+10
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frozencemetery
requested changes
Apr 4, 2022
src/esl-iter.c
Outdated
| @@ -308,13 +308,13 @@ esl_list_iter_next_with_size_correction(esl_list_iter *iter, efi_guid_t *type, | |||
| return -1; | |||
| } | |||
| if (iter->offset < 0) { | |||
| efi_error("iter->offset (%zd) < 0", iter->offset); | |||
| efi_error("iter->offset (%jd) < 0", (uintmax_t) iter->offset); | |||
There was a problem hiding this comment.
off_t is a signed type, so intmax_t is more clear on these, I think. (Also, project style is no space after cast.) This applies to all the iter->offset handling below as well.
On i686 definition of off_t and ssize_t differ. Update format length modifiers as needed to avoid format errors with GCC. Signed-off-by: itd0 <69421122+itd0@users.noreply.github.com>
frozencemetery
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #209
On i686 definition of off_t and ssize_t differ. Update format length
modifiers as needed to avoid format errors with GCC.