Remove deprecated --add-needed linker flag #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves rhboot#204 Signed-off-by: Ali Abdel-Qader <abdelqaderali@protonmail.com>
frozencemetery
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #204
The --add-needed linker flag is not supported by the LLD and Gold linkers, and moreover from what I can tell it doesn't actually serve much of a purpose.
I compiled efivar on Gentoo with --add-needed and with a patch to remove it, and the checksums of the resulting libraries were the same.
If there's any reason that I'm missing for keeping this flag in, please let me know.
Unfortunately this patch still doesn't allow for efivar to be compiled with Clang + LLD, as we get a new error:
ld.lld: error: unable to insert .data after .data