Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLD: fix detection and remove not needed workarounds #222

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

tpgxyz
Copy link
Contributor

@tpgxyz tpgxyz commented Jun 29, 2022

Hi,

This PR fixes:
#220
#219

Copy link
Member

@frozencemetery frozencemetery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to pass CI before it can be considered. (Please drop a message in the comments when it does - github doesn't notify consistently for that.)

@tpgxyz
Copy link
Contributor Author

tpgxyz commented Jul 10, 2022

@frozencemetery CI test pass successful

@frozencemetery
Copy link
Member

CI is not successful. This repository enforces the DCO, and that check has failed because your commits are missing signoff. That's why there's the "Some checks were not successful" message.

Signed-off-by: Tomasz Paweł Gajc <tpgxyz@gmail.com>
@tpgxyz
Copy link
Contributor Author

tpgxyz commented Jul 25, 2022

Signed off has been added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants