Add NO_THREADS variable #238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the user to disable building thread-test to avoid the following build failure without threads raised since version 38 and cff88dd: thread-test.c:14:10: fatal error: pthread.h: No such file or directory 14 | #include <pthread.h> | ^~~~~~~~~~~ Fixes: - http://autobuild.buildroot.org/results/277f783c33102a0cea7c82ca902119ab90f37ad4 Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
|
Why not just install pthreads on your platform? |
|
For that matter, what platform are you using that doesn't expose pthreads? They're part of POSIX. |
|
Because threads are not always available/enabled on some embedded platforms. The build failures are raised by buildroot autobuilders. |
|
If you're not going to tell me what platform you're working on, I'm not going to be able to help you. I don't know anything about buildroot.org - and that's not something we set up, nor are we responsible for it. Clicking around suggests that it's trying to build on Fedora 37. As the maintainer for efivar in Fedora, I can confidently say that we do build there, and that Fedora obviously has pthreads. |
arnout
pushed a commit
to buildroot/buildroot
that referenced
this pull request
Feb 23, 2023
Add a thread dependency as Upstream quickly closed rhboot/efivar#238 to fix the following build failure without threads raised since bump to version 38 in commit f24029b and rhboot/efivar@cff88dd: thread-test.c:14:10: fatal error: pthread.h: No such file or directory 14 | #include <pthread.h> | ^~~~~~~~~~~ Fixes: - http://autobuild.buildroot.org/results/f2da14f91dc602a32dd5b2b7bdf3d3aa43afa7f4 Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
arnout
pushed a commit
to buildroot/buildroot
that referenced
this pull request
Mar 5, 2023
Add a thread dependency as Upstream quickly closed rhboot/efivar#238 to fix the following build failure without threads raised since bump to version 38 in commit f24029b and rhboot/efivar@cff88dd: thread-test.c:14:10: fatal error: pthread.h: No such file or directory 14 | #include <pthread.h> | ^~~~~~~~~~~ Fixes: - http://autobuild.buildroot.org/results/f2da14f91dc602a32dd5b2b7bdf3d3aa43afa7f4 Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> (cherry picked from commit c29f6d6) Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the user to disable building thread-test to avoid the following build failure without threads raised since version 38 and cff88dd:
Fixes: